From: | Yurii Rashkovskii <yrashk(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Cary Huang <cary(dot)huang(at)highgo(dot)ca> |
Subject: | Re: [PATCH] Allow Postgres to pick an unused port to listen |
Date: | 2023-05-11 07:01:37 |
Message-ID: | CA+RLCQy1FjPpSWxgJMPXA4xe64kXsEEtXwcVtcbNPAMscZt0qA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro, Tom,
On Mon, May 8, 2023 at 4:49 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > This made me wonder if storing the unadorned port number is really the
> > best way. Suppose we did extend things so that we listen on different
> > ports on different interfaces; how would this scheme work at all?
>
> Yeah, the probability that that will happen someday is one of the
> things bothering me about this proposal. I'd rather change the
> file format to support that first (it can be dummy for now, with
> all lines showing the same port), and then document it second.
>
How soon do you think the change will occur that will allow for choosing
different ports on different interfaces? I am happy to help address this.
Relying on a variable number of lines may be counter-productive here if we
want postmaster.pid to be easily readable by shell scripts. What if we
improved the port line to be something like this?
```
127.0.0.1=5432 ::1=54321
```
Basically, a space-delimited set of address/port pairs (delimited by `=` to
allow IPv6 addresses to use a colon). If we allow the address side to be
dropped, the current format (`5432`) will also be correct parsing-wise.
--
Y.
From | Date | Subject | |
---|---|---|---|
Next Message | Drouvot, Bertrand | 2023-05-11 07:09:53 | Re: Add two missing tests in 035_standby_logical_decoding.pl |
Previous Message | Yurii Rashkovskii | 2023-05-11 06:46:30 | Re: [PATCH] Allow Postgres to pick an unused port to listen |