| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Joe Conway <mail(at)joeconway(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix typos and bump catversion. |
| Date: | 2022-11-19 22:16:18 |
| Message-ID: | 20221119221618.ukkzaj3lilrrt52o@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2022-11-19 17:10:57 -0500, Joe Conway wrote:
> Rishu Bagga pointed out to me offlist that this catversion bump seems
> flawed:
>
> diff --git a/src/include/catalog/catversion.h
> b/src/include/catalog/catversion.h
> index c6ef593207c227ce10b0c897379476b553974f67..b3a57136b755fed182b4518330e65786032db870
> 100644 (file)
> --- a/src/include/catalog/catversion.h
> +++ b/src/include/catalog/catversion.h
> @@ -57,6 +57,6 @@
> */
>
> /* yyyymmddN */
> -#define CATALOG_VERSION_NO 202211121
> +#define CATALOG_VERSION_NO 202211821
>
> #endif
>
> I think that should be 202211181, no? I am not clear on the desirable way to
> fix though :-/
I think it's fine to just update to a "normal" catversion. We really just
match for an exact match with a few exceptions (somewhere in pg_upgrade IIRC),
and those exceptions don't really matter for some individual commit on the
development branch.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-11-19 22:24:50 | Re: pgsql: Fix typos and bump catversion. |
| Previous Message | Joe Conway | 2022-11-19 22:10:57 | Re: pgsql: Fix typos and bump catversion. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-11-19 22:24:50 | Re: pgsql: Fix typos and bump catversion. |
| Previous Message | Andres Freund | 2022-11-19 22:14:17 | Re: CI and test improvements |