Re: pgsql: Fix typos and bump catversion.

From: Joe Conway <mail(at)joeconway(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: pgsql: Fix typos and bump catversion.
Date: 2022-11-19 22:10:57
Message-ID: 1e37f7d5-08a7-fbfb-da2e-b4aa5f409e01@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 11/18/22 16:18, Robert Haas wrote:
> Fix typos and bump catversion.
>
> Typos reported by Álvaro Herrera and Erik Rijkers.
>
> Catversion bump for 3d14e171e9e2236139e8976f3309a588bcc8683b was
> inadvertently omitted.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/2fb6154fcd769b2d4ea1226788e0ec2fc3522cb8
>
> Modified Files
> --------------
> doc/src/sgml/ref/grant.sgml | 2 +-
> src/bin/pg_dump/pg_dumpall.c | 1 -
> src/include/catalog/catversion.h | 2 +-

Rishu Bagga pointed out to me offlist that this catversion bump seems
flawed:

diff --git a/src/include/catalog/catversion.h
b/src/include/catalog/catversion.h
index
c6ef593207c227ce10b0c897379476b553974f67..b3a57136b755fed182b4518330e65786032db870
100644 (file)
--- a/src/include/catalog/catversion.h
+++ b/src/include/catalog/catversion.h
@@ -57,6 +57,6 @@
*/

/* yyyymmddN */
-#define CATALOG_VERSION_NO 202211121
+#define CATALOG_VERSION_NO 202211821

#endif

I think that should be 202211181, no? I am not clear on the desirable
way to fix though :-/

Joe
--
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-11-19 22:16:18 Re: pgsql: Fix typos and bump catversion.
Previous Message Andres Freund 2022-11-19 21:56:50 pgsql: Fix mislabeling of PROC_QUEUE->links as PGPROC, fixing UBSan on

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-11-19 22:14:17 Re: CI and test improvements
Previous Message Justin Pryzby 2022-11-19 21:45:06 Re: CI and test improvements