Re: pgsql: Fix typos and bump catversion.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Joe Conway <mail(at)joeconway(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix typos and bump catversion.
Date: 2022-11-19 22:24:50
Message-ID: 2655402.1668896690@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-11-19 17:10:57 -0500, Joe Conway wrote:
>> Rishu Bagga pointed out to me offlist that this catversion bump seems
>> flawed:
>> /* yyyymmddN */
>> -#define CATALOG_VERSION_NO 202211121
>> +#define CATALOG_VERSION_NO 202211821

>> I think that should be 202211181, no? I am not clear on the desirable way to
>> fix though :-/

> I think it's fine to just update to a "normal" catversion.

Yeah, just fix it --- and the sooner the better, to avoid the risk
that this becomes a value that someone needs to care about.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Joe Conway 2022-11-19 22:57:28 pgsql: Fix catversion
Previous Message Andres Freund 2022-11-19 22:16:18 Re: pgsql: Fix typos and bump catversion.

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2022-11-19 23:01:18 Re: pgsql: Fix typos and bump catversion.
Previous Message Andres Freund 2022-11-19 22:16:18 Re: pgsql: Fix typos and bump catversion.