From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
Cc: | bdrouvot(at)amazon(dot)com, sawada(dot)mshk(at)gmail(dot)com, ashutosh(dot)bapat(dot)oss(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: more descriptive message for process termination due to max_slot_wal_keep_size |
Date: | 2022-09-30 02:15:19 |
Message-ID: | 20220930.111519.865126851436936262.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Thu, 29 Sep 2022 13:31:00 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in
> Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> writes:
> > At Wed, 28 Sep 2022 16:30:37 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in
> > LOG: invalidating *replication* slot \"%s\"
> > DETAILS: (ditto)
> > HINTS: (ditto)
>
> I thought the latter was a little *too* short; the primary message
> should at least give you some clue why that happened, even if it
> doesn't offer all the detail. After some thought I changed it to
Yeah, agreed. It looks better. (I was about to spell it as
"invalidating slot "%s"" then changed my mind to add "replication". I
felt that it is a bit too short but didn't think about further
streaching that by adding "obsolete"..).
> LOG: invalidating obsolete replication slot \"%s\"
>
> and pushed it that way.
Thanks. And thanks for fixing the test script, too.
By the way, I didn't notice at that time (and forgot about the
policy), but the HINT message has variations differing only by the
variable name.
What do you think about the attached?
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
unify_you_migh_need_to_increase_messages.patch | text/x-patch | 5.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-09-30 02:16:10 | Re: longfin and tamandua aren't too happy but I'm not sure why |
Previous Message | Thomas Munro | 2022-09-30 02:11:49 | Re: Introduce wait_for_subscription_sync for TAP tests |