| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | bdrouvot(at)amazon(dot)com |
| Cc: | andres(at)anarazel(dot)de, stark(at)mit(dot)edu, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: shared-memory based stats collector - v70 |
| Date: | 2022-08-22 02:32:14 |
| Message-ID: | 20220822.113214.157880042751504547.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Wed, 10 Aug 2022 14:02:34 +0200, "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> wrote in
> what about?
>
> + /*
> + * Acquire the LWLock directly instead of using
> pg_stat_lock_entry_shared()
> + * which requires a reference.
> + */
>
>
> I think that's more consistent with other comments mentioning LWLock
> acquisition.
Sure. Thaks!. I did that in the attached.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Acquire-lock-properly-when-building-stats-snapsho.patch | text/x-patch | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2022-08-22 02:35:34 | Re: [PATCH] Optimize json_lex_string by batching character copying |
| Previous Message | Michael Paquier | 2022-08-22 00:42:50 | Re: pg_receivewal and SIGTERM |