| From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | <andres(at)anarazel(dot)de>, <stark(at)mit(dot)edu>, <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: shared-memory based stats collector - v70 |
| Date: | 2022-08-22 05:51:39 |
| Message-ID: | 67f847bb-a1c2-f444-b2e0-333a97f1953a@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 8/22/22 4:32 AM, Kyotaro Horiguchi wrote:
> At Wed, 10 Aug 2022 14:02:34 +0200, "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> wrote in
>> what about?
>>
>> + /*
>> + * Acquire the LWLock directly instead of using
>> pg_stat_lock_entry_shared()
>> + * which requires a reference.
>> + */
>>
>>
>> I think that's more consistent with other comments mentioning LWLock
>> acquisition.
> Sure. Thaks!. I did that in the attached.
Thank you!
The patch looks good to me.
Regards,
Bertrand
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Natarajan R | 2022-08-22 06:29:05 | Logical replication support for generic wal record |
| Previous Message | John Naylor | 2022-08-22 04:50:35 | Re: use ARM intrinsics in pg_lfind32() where available |