Re: doc phrase: "inheritance child"

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Subject: Re: doc phrase: "inheritance child"
Date: 2022-06-30 09:55:36
Message-ID: 20220630095536.GT28130@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 27, 2022 at 03:22:38PM +0900, Amit Langote wrote:
> On Wed, May 25, 2022 at 1:30 PM Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> > <para>
> > - If true, the stats include inheritance child columns, not just the
> > + If true, the stats include child tables, not just the
> >
> > We are replacing columns with tables; is that intentional?
> >
> > Partitioned tables do not have their own stats, it's just aggregated partition stats.
> > ...
> > - If true, the stats include inheritance child columns, not just the
> > + If true, the stats include child childs, not just the
> > values in the specified relation
> > </para></entry>
> > </row>
> > @@ -13152,7 +13152,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
> > <structfield>inherited</structfield> <type>bool</type>
> > </para>
> > <para>
> > - If true, this row includes inheritance child columns, not just the
> > + If true, this row includes child tables, not just the
> > values in the specified table
> > </para></entry>
> > </row>
> >
> > Replacing inheritance child "column" with "tables", is that intentional?
>
> I was a bit confused by these too, though perhaps the original text is
> not as clear as it could be? Would the following be a good rewrite:

I updated the language to say "values from". Is this better ?

And rebased to include changes to 401f623c7.

BTW nobody complained about my "child child" typo.

--
Justin

Attachment Content-Type Size
0001-doc-avoid-saying-inheritence-when-it-applies-to-part.patch text/x-diff 4.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-06-30 09:57:30 Re: Add index item for MERGE.
Previous Message Graham Leggett 2022-06-30 09:53:58 Re: [PATCH] Log details for client certificate failures