Re: doc phrase: "inheritance child"

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Subject: Re: doc phrase: "inheritance child"
Date: 2022-07-05 07:36:08
Message-ID: CA+HiwqEj5Nudu4fGnrH08yvsQz9NGN_XXRUMEcGjfVcG5S2zuA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 30, 2022 at 6:55 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> On Fri, May 27, 2022 at 03:22:38PM +0900, Amit Langote wrote:
> > On Wed, May 25, 2022 at 1:30 PM Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> > > <para>
> > > - If true, the stats include inheritance child columns, not just the
> > > + If true, the stats include child tables, not just the
> > >
> > > We are replacing columns with tables; is that intentional?
> > >
> > > Partitioned tables do not have their own stats, it's just aggregated partition stats.
> > > ...
> > > - If true, the stats include inheritance child columns, not just the
> > > + If true, the stats include child childs, not just the
> > > values in the specified relation
> > > </para></entry>
> > > </row>
> > > @@ -13152,7 +13152,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
> > > <structfield>inherited</structfield> <type>bool</type>
> > > </para>
> > > <para>
> > > - If true, this row includes inheritance child columns, not just the
> > > + If true, this row includes child tables, not just the
> > > values in the specified table
> > > </para></entry>
> > > </row>
> > >
> > > Replacing inheritance child "column" with "tables", is that intentional?
> >
> > I was a bit confused by these too, though perhaps the original text is
> > not as clear as it could be? Would the following be a good rewrite:
>
> I updated the language to say "values from". Is this better ?

Yes.

--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-07-05 07:37:24 Re: Patch proposal: New hooks in the connection path
Previous Message Masahiko Sawada 2022-07-05 07:33:29 Re: [PoC] Improve dead tuple storage for lazy vacuum