Re: doc phrase: "inheritance child"

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Subject: Re: doc phrase: "inheritance child"
Date: 2022-05-27 06:22:38
Message-ID: CA+HiwqFaDCNDimk=ibRY-AHccr5TmwOUN-uWnRq--6Xyk0w1Kw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 25, 2022 at 1:30 PM Ashutosh Bapat
<ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> <para>
> - If true, the stats include inheritance child columns, not just the
> + If true, the stats include child tables, not just the
>
> We are replacing columns with tables; is that intentional?
>
> Partitioned tables do not have their own stats, it's just aggregated partition stats.
> ...
> - If true, the stats include inheritance child columns, not just the
> + If true, the stats include child childs, not just the
> values in the specified relation
> </para></entry>
> </row>
> @@ -13152,7 +13152,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
> <structfield>inherited</structfield> <type>bool</type>
> </para>
> <para>
> - If true, this row includes inheritance child columns, not just the
> + If true, this row includes child tables, not just the
> values in the specified table
> </para></entry>
> </row>
>
> Replacing inheritance child "column" with "tables", is that intentional?

I was a bit confused by these too, though perhaps the original text is
not as clear as it could be? Would the following be a good rewrite:

If true, the stats cover the contents not only of the specified table,
but also of its child tables or partitions. (If the table is
partitioned, which contains no data by itself, the stats only cover
the contents of partitions).

Although, maybe the parenthetical is unnecessary.

--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2022-05-27 06:30:28 Prevent writes on large objects in read-only transactions
Previous Message Justin Pryzby 2022-05-27 05:53:31 Re: bogus: logical replication rows/cols combinations