| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Lukas Fittl <lukas(at)fittl(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, melanieplageman(at)gmail(dot)com, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: shared-memory based stats collector - v70 |
| Date: | 2022-04-06 19:34:19 |
| Message-ID: | 20220406193419.GA24419@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 06, 2022 at 12:27:34PM -0700, Andres Freund wrote:
> > > + next use of statistical information will cause a new snapshot to be built
> > > + or accessed statistics to be cached.
> >
> > I believe this should be an "and", not an "or". (next access builds both a
> > new snapshot and caches accessed statistics)
>
> I *think* or is correct? The new snapshot is when stats_fetch_consistency =
> snapshot, the cached is when stats_fetch_consistency = cache. Not sure how to
> make that clearer without making it a lot longer. Suggestions?
I think it's correct. Maybe it's clearer to say:
+ next use of statistical information will (when in snapshot mode) cause a new snapshot to be built
+ or (when in cache mode) accessed statistics to be cached.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Lukas Fittl | 2022-04-06 19:37:20 | Re: shared-memory based stats collector - v70 |
| Previous Message | Stephen Frost | 2022-04-06 19:29:15 | Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file |