|From:||Stephen Frost <sfrost(at)snowman(dot)net>|
|To:||Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>|
|Cc:||Nathan Bossart <nathandbossart(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Chapman Flack <chap(at)anastigmatix(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org|
|Subject:||Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
* Laurenz Albe (laurenz(dot)albe(at)cybertec(dot)at) wrote:
> On Tue, 2022-04-05 at 13:06 -0700, Nathan Bossart wrote:
> > On Tue, Apr 05, 2022 at 11:25:36AM -0400, Stephen Frost wrote:
> > > Please find attached an updated patch + commit message. Mostly, I just
> > > went through and did a bit more in terms of updating the documentation
> > > and improving the comments (there were some places that were still
> > > worrying about the chance of a 'stray' backup_label file existing, which
> > > isn't possible any longer), along with some additional testing and
> > > review. This is looking pretty good to me, but other thoughts are
> > > certainly welcome. Otherwise, I'm hoping to commit this tomorrow.
> > LGTM!
> Cassandra (not the software) from the sidelines predicts that we will
> get some fire from users for this, although I concede the theoretical
> sanity of the change.
Great, thanks for that.
This has now been committed- thanks again to everyone for their help!
|Next Message||Justin Pryzby||2022-04-06 19:34:19||Re: shared-memory based stats collector - v70|
|Previous Message||Andres Freund||2022-04-06 19:27:34||Re: shared-memory based stats collector - v70|