| From: | Lukas Fittl <lukas(at)fittl(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, melanieplageman(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: shared-memory based stats collector - v70 |
| Date: | 2022-04-06 19:37:20 |
| Message-ID: | CAP53PkynGdV-xff8p2mdQ3WAw+N6darMZpKzu=mj1cNvrQmWXQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 6, 2022 at 12:34 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> On Wed, Apr 06, 2022 at 12:27:34PM -0700, Andres Freund wrote:
> > > > + next use of statistical information will cause a new snapshot to
> be built
> > > > + or accessed statistics to be cached.
> > >
> > > I believe this should be an "and", not an "or". (next access builds
> both a
> > > new snapshot and caches accessed statistics)
> >
> > I *think* or is correct? The new snapshot is when
> stats_fetch_consistency =
> > snapshot, the cached is when stats_fetch_consistency = cache. Not sure
> how to
> > make that clearer without making it a lot longer. Suggestions?
>
> I think it's correct. Maybe it's clearer to say:
>
> + next use of statistical information will (when in snapshot mode) cause
> a new snapshot to be built
> + or (when in cache mode) accessed statistics to be cached.
>
Ah, yes, that does clarify what was meant.
+1 to Justin's edit, or something like it.
Thanks,
Lukas
--
Lukas Fittl
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-04-06 19:40:39 | Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file |
| Previous Message | Justin Pryzby | 2022-04-06 19:34:19 | Re: shared-memory based stats collector - v70 |