| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | kuroda(dot)hayato(at)fujitsu(dot)com |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com, zyu(at)yugabyte(dot)com, masao(dot)fujii(at)oss(dot)nttdata(dot)com |
| Subject: | Re: [Proposal] Add foreign-server health checks infrastructure |
| Date: | 2022-02-17 08:14:05 |
| Message-ID: | 20220217.171405.1911593760090019851.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Thu, 17 Feb 2022 04:32:26 +0000, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> wrote in
> > I understood here as removing following mechanism from core:
> >
> > * disable timeout at end of tx.
>
> While reading again and this part might be wrong.
> Sorry for inconvenience.
> But anyway some codes should be (re)moved from core, right?
I think we just don't need to add the special timeout kind to the
core. postgres_fdw can use USER_TIMEOUT and it would be suffiction to
keep running health checking regardless of transaction state then fire
query cancel if disconnection happens. As I said in the previous main,
possible extra query cancel woud be safe.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-02-17 08:24:58 | Re: [PATCH] Fix out-of-bouds access (src/common/wchar.c) |
| Previous Message | Kyotaro Horiguchi | 2022-02-17 08:08:32 | Re: [Proposal] Add foreign-server health checks infrastructure |