Re: automatic analyze: readahead - add "IO read time" log message

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Egor Rogov <e(dot)rogov(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: automatic analyze: readahead - add "IO read time" log message
Date: 2021-08-27 23:24:55
Message-ID: 20210827232454.GZ17906@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> * Egor Rogov (e(dot)rogov(at)postgrespro(dot)ru) wrote:
> > On 11.02.2021 01:10, Stephen Frost wrote:
> > >* Heikki Linnakangas (hlinnaka(at)iki(dot)fi) wrote:
> > >>On 05/02/2021 23:22, Stephen Frost wrote:
> > >>>Unless there's anything else on this, I'll commit these sometime next
> > >>>week.
> > >>One more thing: Instead of using 'effective_io_concurrency' GUC directly,
> > >>should call get_tablespace_maintenance_io_concurrency().
> > >Ah, yeah, of course.
> > >
> > >Updated patch attached.
> >
> > I happened to notice that get_tablespace_io_concurrency() is called instead
> > of get_tablespace_maintenance_io_concurrency(). It doesn't look right, no?
>
> Hah, indeed you're right. Will fix.

Found this under a bit of a pile in my todo list. :)

Fix pushed.

Thanks!

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Denis Smirnov 2021-08-28 00:45:57 Re: Async-unsafe functions in signal handlers
Previous Message Tom Lane 2021-08-27 22:51:02 Re: Can we get rid of repeated queries from pg_dump?