Re: automatic analyze: readahead - add "IO read time" log message

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Egor Rogov <e(dot)rogov(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: automatic analyze: readahead - add "IO read time" log message
Date: 2021-05-26 00:36:52
Message-ID: 20210526003652.GV20766@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Egor Rogov (e(dot)rogov(at)postgrespro(dot)ru) wrote:
> On 11.02.2021 01:10, Stephen Frost wrote:
> >* Heikki Linnakangas (hlinnaka(at)iki(dot)fi) wrote:
> >>On 05/02/2021 23:22, Stephen Frost wrote:
> >>>Unless there's anything else on this, I'll commit these sometime next
> >>>week.
> >>One more thing: Instead of using 'effective_io_concurrency' GUC directly,
> >>should call get_tablespace_maintenance_io_concurrency().
> >Ah, yeah, of course.
> >
> >Updated patch attached.
>
> I happened to notice that get_tablespace_io_concurrency() is called instead
> of get_tablespace_maintenance_io_concurrency(). It doesn't look right, no?

Hah, indeed you're right. Will fix.

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2021-05-26 00:49:11 Re: Add ZSON extension to /contrib/
Previous Message Justin Pryzby 2021-05-26 00:13:59 Re: fdatasync performance problem with large number of DB files