| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Bernd Helmle <mailings(at)oopsware(dot)de>, Mathis Rudolf <mathis(dot)rudolf(at)credativ(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Alias collision in `refresh materialized view concurrently` |
| Date: | 2021-06-02 10:14:45 |
| Message-ID: | CALj2ACURRvCf=nOF=Kve1qLS5bFfwLy5Nc9=+HFCX6WSk-f5mA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 2, 2021 at 1:27 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Jun 02, 2021 at 10:53:22AM +0530, Bharath Rupireddy wrote:
> > Thanks. PSA v4.
>
> Thanks for the new version.
>
> + MyProcPid, tempname, MyProcPid, MyProcPid,
> + tempname, MyProcPid, MyProcPid, MyProcPid,
> + MyProcPid, MyProcPid, MyProcPid);
> This style is still a bit heavy-ish. Perhaps we should just come back
> to Thomas's suggestion and just use a prefix with _$ for all that.
Thanks.The changes with that approach are very minimal. PSA v5 and let
me know if any more changes are needed.
With Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Avoid-alias-name-collisions-in-REFRESH-MATERIALIZ.patch | application/x-patch | 4.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-06-02 10:57:01 | Re: Fixup some appendStringInfo and appendPQExpBuffer calls |
| Previous Message | tanghy.fnst@fujitsu.com | 2021-06-02 09:50:51 | tab-complete for CREATE TYPE ... SUBSCRIPT |