| From: | 'Alvaro Herrera' <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
| Cc: | "iwata(dot)aya(at)fujitsu(dot)com" <iwata(dot)aya(at)fujitsu(dot)com>, "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com>, "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: libpq debug log |
| Date: | 2021-02-09 10:47:43 |
| Message-ID: | 20210209104743.GA30101@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Feb-04, tsunakawa(dot)takay(at)fujitsu(dot)com wrote:
> From: 'Alvaro Herrera' <alvherre(at)alvh(dot)no-ip(dot)org>
> > > (41)
> > > +void
> > > +PQtraceEx(PGconn *conn, FILE *debug_port, int flags)
> > > +{
> >
> > I'm not really sure about making this a separate API call. We could just
> > make it PQtrace() and increment the libpq so version. I don't think
> > it's a big deal, frankly.
>
> If we change the function signature, we have to bump the so major version and thus soname. The libpq's current so major version is 5, which hasn't been changed since 2006. I'm hesitant to change it for this feature. If you think we can bump the version to 6, I think we can go.
I think it's pretty clear we would not change the so-version for this
feature.
--
Álvaro Herrera 39°49'30"S 73°17'W
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-02-09 10:51:22 | Re: libpq debug log |
| Previous Message | Alvaro Herrera | 2021-02-09 10:46:37 | Re: pg_replication_origin_drop API potential race condition |