RE: libpq debug log

From: "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>
To: 'Alvaro Herrera' <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: "iwata(dot)aya(at)fujitsu(dot)com" <iwata(dot)aya(at)fujitsu(dot)com>, "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com>, "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: libpq debug log
Date: 2021-02-04 01:50:01
Message-ID: TYAPR01MB2990522654120C921EF76D3DFEB39@TYAPR01MB2990.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: 'Alvaro Herrera' <alvherre(at)alvh(dot)no-ip(dot)org>
> > (41)
> > +void
> > +PQtraceEx(PGconn *conn, FILE *debug_port, int flags)
> > +{
>
> I'm not really sure about making this a separate API call. We could just
> make it PQtrace() and increment the libpq so version. I don't think
> it's a big deal, frankly.

If we change the function signature, we have to bump the so major version and thus soname. The libpq's current so major version is 5, which hasn't been changed since 2006. I'm hesitant to change it for this feature. If you think we can bump the version to 6, I think we can go.

https://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html
--------------------------------------------------
try to make sure that your libraries are either backwards-compatible or that you've incremented the version number in the soname every time you make an incompatible change.

When a new version of a library is binary-incompatible with the old one the soname needs to change. In C, there are four basic reasons that a library would cease to be binary compatible:

1. The behavior of a function changes so that it no longer meets its original specification,

2. Exported data items change (exception: adding optional items to the ends of structures is okay, as long as those structures are only allocated within the library).

3. An exported function is removed.

4. The interface of an exported function changes.
--------------------------------------------------

Regards
Takayuki Tsunakawa

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-02-04 01:50:45 Re: Bug in COPY FROM backslash escaping multi-byte chars
Previous Message Mark Dilger 2021-02-04 01:48:35 possibly outdated pg_file_read() errhint