Context diffs

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Context diffs
Date: 2021-01-04 19:07:10
Message-ID: 20210104190710.GF7432@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Our developer FAQ mentions context diffs in several places for their
improved readability:

https://wiki.postgresql.org/wiki/Developer_FAQ

I also know git can product context diff as _output_. However, there
are several negatives to context vs unified diffs in our workflow:

* "git apply" and "git am" can't process context diffs (they throw an
error once a context-like section of the diff is hit; simple
adding/removing lines in a block works)

* the commit-fest doesn't recognized context diff attachments as
patches:

https://commitfest.postgresql.org/31/2912/

* cfbot can't process file renames/add/delete from context diffs

I am not 100% sure on the above items, but that is what I have seen in
my testing. Should we post only unified diffs in certain cases, even
with the readability issues? (I know some people prefer the readability
of unified diffs.) Should we document this?

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-01-04 19:42:16 Re: Context diffs
Previous Message Bruce Momjian 2021-01-04 18:23:29 Re: Proposed patch for key management