| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Brar Piening <brar(at)gmx(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Minor documentation error regarding streaming replication protocol |
| Date: | 2020-12-15 09:22:44 |
| Message-ID: | 2bf2c26afb2e3f61a3ebeba0070dc90d048d9003.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 2020-12-03 at 13:14 -0500, Bruce Momjian wrote:
> Andres objected (in a separate conversation) to forcing a binary-
> > format
> > value on a client that didn't ask for one. He suggested that we
> > mandate
> > that the data is ASCII-only (for both filename and content),
> > closing
> > the gap Michael raised[1]; and then just declare all values to be
> > text
> > format.
>
> How do we mandate that? Just mention it in the docs and C comments?
Attached a simple patch that enforces an all-ASCII restore point name
rather than documenting the possibility of non-ASCII text.
Regards,
Jeff Davis
[1]
https://www.postgresql.org/message-id/3679218.1602770626%40sss.pgh.pa.us
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Enforce-ASCII-restore-point-names.patch | text/x-patch | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2020-12-15 10:01:41 | Re: Single transaction in the tablesync worker? |
| Previous Message | Dilip Kumar | 2020-12-15 09:20:14 | Re: Parallel Inserts in CREATE TABLE AS |