Re: Add docs stub for recovery.conf

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add docs stub for recovery.conf
Date: 2020-11-30 18:42:07
Message-ID: 20201130184207.GD3453@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 30, 2020 at 11:31:35AM -0700, David G. Johnston wrote:
> On Mon, Nov 30, 2020 at 11:25 AM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> On Mon, Nov 30, 2020 at 10:11:04AM +0800, Craig Ringer wrote:
> > Can we please just address this docs issue? If you don't like my solution
> can
> > you please supply a patch that you feel addresses the problem? Or clearly
> state
> > that you don't think there is a problem, and do so in a way that actually
> > addresses the specific points I have raised about what's wrong with the
> status
> > quo?
>
> If we know there are X problems, and we fix one of them one way, then
> later fix the rest another way, we have to undo the first fix.  If you
> don't want to fix all X, then let's wait until someone does want to fix
> them all.
>
> IMO there is only the original problem with an acceptable solution presented
> that can be committed without downside.  If that has to be undone because
> someone else in the future decides on a different solution that happens to
> touch this too, fine, it can be changed again.

The downside is you end up with X-1 dummy sections just to allow for
references to old syntax, and you then have to find them all and remove
them when you implement the proper solution. I have no intention of
applying such an X-1 fix.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Anastasia Lubennikova 2020-11-30 18:51:12 Re: [PATCH] remove deprecated v8.2 containment operators
Previous Message Peter Eisentraut 2020-11-30 18:37:36 Re: Improve handling of parameter differences in physical replication