Re: Online checksums patch - once again

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Online checksums patch - once again
Date: 2020-09-24 04:27:42
Message-ID: 20200924042742.GL28585@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 23, 2020 at 02:34:36PM +0200, Daniel Gustafsson wrote:
> While in the patch I realized that the relationlist saved the relkind but the
> code wasn't actually using it, so I've gone ahead and removed that with a lot
> fewer palloc calls as a result. The attached v22 fixes that and the above.

Some of the TAP tests are blowing up here, as the CF bot is telling:
t/003_standby_checksum.pl .. 1/11 # Looks like you planned 11 tests but ran 4.
# Looks like your test exited with 29 just after 4.
t/003_standby_checksum.pl .. Dubious, test returned 29 (wstat 7424, 0x1d00)
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-09-24 04:51:39 Re: [HACKERS] make async slave to wait for lsn to be replayed
Previous Message tsunakawa.takay@fujitsu.com 2020-09-24 04:26:37 RE: [Patch] Optimize dropping of relation buffers using dlist