| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Online checksums patch - once again |
| Date: | 2020-09-24 07:24:19 |
| Message-ID: | 78758C8D-9F6C-4D73-8A4A-E48283DD434F@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 24 Sep 2020, at 06:27, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Sep 23, 2020 at 02:34:36PM +0200, Daniel Gustafsson wrote:
>> While in the patch I realized that the relationlist saved the relkind but the
>> code wasn't actually using it, so I've gone ahead and removed that with a lot
>> fewer palloc calls as a result. The attached v22 fixes that and the above.
>
> Some of the TAP tests are blowing up here, as the CF bot is telling:
> t/003_standby_checksum.pl .. 1/11 # Looks like you planned 11 tests but ran 4.
> # Looks like your test exited with 29 just after 4.
> t/003_standby_checksum.pl .. Dubious, test returned 29 (wstat 7424, 0x1d00)
Interesting, I've been unable to trigger a fault and the latest Travis build
was green. I'll continue to try and see if I can shake something loose.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Katsuragi Yuta | 2020-09-24 07:32:51 | Re: [PATCH] Add features to pg_stat_statements |
| Previous Message | Michael Paquier | 2020-09-24 07:12:53 | Re: Range checks of pg_test_fsync --secs-per-test and pg_test_timing --duration |