| From: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
|---|---|
| To: | "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com> |
| Cc: | 'Kyotaro Horiguchi' <horikyota(dot)ntt(at)gmail(dot)com>, "amit(dot)kapila16(at)gmail(dot)com" <amit(dot)kapila16(at)gmail(dot)com>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, "tomas(dot)vondra(at)2ndquadrant(dot)com" <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: [Patch] Optimize dropping of relation buffers using dlist |
| Date: | 2020-09-24 04:26:37 |
| Message-ID: | TYAPR01MB2990CF10F21BFD6CC63AE5A8FE390@TYAPR01MB2990.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
In v15:
(1)
+ for (cur_blk = firstDelBlock[j]; cur_blk < nblocks; cur_blk++)
The right side of "cur_blk <" should not be nblocks, because nblocks is not the number of the relation fork anymore.
(2)
+ BlockNumber nblocks;
+ nblocks = smgrnblocks(smgr_reln, forkNum[j]) - firstDelBlock[j];
You should either:
* Combine the two lines into one: BlockNumber nblocks = ...;
or
* Put an empty line between the two lines to separate declarations and execution statements.
After correcting these, I think you can check the recovery performance.
Regards
Takayuki Tsunakawa
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-09-24 04:27:42 | Re: Online checksums patch - once again |
| Previous Message | Tom Lane | 2020-09-24 04:26:32 | Re: The ultimate extension hook. |