From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: TAP tests and symlinks on Windows |
Date: | 2020-06-29 07:56:16 |
Message-ID: | 20200629075616.GC330401@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jun 26, 2020 at 02:00:37PM +0200, Peter Eisentraut wrote:
> We should be more accurate about things like this:
>
> +# The following tests test symlinks. Windows may not have symlinks, so
> +# skip there.
>
> The issue isn't whether Windows has symlinks, since all versions of Windows
> supported by PostgreSQL do (AFAIK). The issue is only whether the Perl
> installation that runs the tests has symlink support. And that is only
> necessary if the test itself wants to create or inspect symlinks. For
> example, there are existing tests involving tablespaces that work just fine
> on Windows.
Check. Indeed that sounds confusing.
> Relatedly, your patch ends up skipping the tests on MSYS2, even though Perl
> supports symlinks there out of the box.
Do you think that it would be enough to use what Andrew has mentioned
in [1]? I don't have a MSYS2 installation, so I am unfortunately not
able to confirm that, but I would just move the check to TestLib.pm
and save it in an extra variable.
[1]: https://www.postgresql.org/message-id/6c5ffed0-20ee-8878-270f-ab56b7023802@2ndQuadrant.com
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2020-06-29 08:27:41 | Re: [Bug fix]There is the case archive_timeout parameter is ignored after recovery works. |
Previous Message | Michael Paquier | 2020-06-29 07:48:58 | Re: pg_bsd_indent compiles bytecode |