| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | James Coleman <jtc331(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se> |
| Subject: | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Date: | 2020-05-09 22:19:45 |
| Message-ID: | 20200509221945.yxixm2evfukdg4ic@development |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 09, 2020 at 10:50:12PM +0200, Tomas Vondra wrote:
>On Sat, May 09, 2020 at 03:18:36PM -0500, Justin Pryzby wrote:
>>Checking if it's possible to address this Opened Item before 13b1.
>>
>>https://wiki.postgresql.org/wiki/PostgreSQL_13_Open_Items
>>consistency of explain output: two spaces, equals vs colons, semicolons (incremental sort)
>>
>
>Yes. Now that the other items related to incremental sort are fixed,
>this is next on my TODO.
>
OK, so aside from the typo/comment fixes, the proposed changes to the
explain format are:
- two spaces to separate groups of related values
- use colons rather than equals for fields
- don't use semicolons
- split full-groups and prefix-groups to separate lines
I'm generally OK with most of this - I'd probably keep the single-line
format, but I don't feel very strongly about that and if others think
using two lines is better ...
Barring objections I'll get this polished and pushed soon-ish (say,
early next week).
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-05-09 23:11:56 | Re: Add -Wold-style-definition to CFLAGS? |
| Previous Message | Ranier Vilela | 2020-05-09 21:11:56 | Re: [PATCH] Fix division by zero (explain.c) |