Re: Add -Wold-style-definition to CFLAGS?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add -Wold-style-definition to CFLAGS?
Date: 2020-05-09 23:11:56
Message-ID: 19295.1589065916@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2020-05-09 14:15:01 -0400, Tom Lane wrote:
>> Andres Freund <andres(at)anarazel(dot)de> writes:
>>> Since gcc has a warning detecting such definition, I think we ought to
>>> automatically add it when available?

>> +1

> Any opinion about waiting for branching or not?

I'd be OK with pushing it now, but I dunno about other people.

If we do want to push this sort of thing now, the nearby changes
to enable fallthrough warnings should go in too.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-05-10 01:37:59 Re: Add -Wold-style-definition to CFLAGS?
Previous Message Tomas Vondra 2020-05-09 22:19:45 Re: [PATCH] Incremental sort (was: PoC: Partial sort)