| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | James Coleman <jtc331(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se> |
| Subject: | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Date: | 2020-04-07 02:53:05 |
| Message-ID: | 20200407025305.hss7dd2qgd7s54on@development |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 06, 2020 at 10:19:41PM -0400, Tom Lane wrote:
>James Coleman <jtc331(at)gmail(dot)com> writes:
>> Fair enough. Unsure if Tomas is still online to comment and/or push,
>> but reverting SORT_TYPE_STILL_IN_PROGRESS back to 0 works for me as an
>> initial fix.
>
>I'm guessing he went to bed, so I'll push a fix in a moment.
>The patch has survived enough test cycles here now to make me
>moderately confident that it fixes the issue.
>
Nope, how I could I sleep with half of the buildfarm still red?
I came to the same conclusion (that the change in TuplesortMethod
definiton is the culprit) a while ago and was about to push a fix that
initialized it correctly in ExecSortInitializeDSM. But I agree reverting
it back to the old definition is probably better.
Thanks!
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-04-07 03:00:37 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Previous Message | Zhang, Jie | 2020-04-07 02:42:40 | [patch] some PQExpBuffer are not destroyed in pg_dump |