[patch] some PQExpBuffer are not destroyed in pg_dump

From: "Zhang, Jie" <zhangjie2(at)cn(dot)fujitsu(dot)com>
To: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: "Zhang, Jie" <zhangjie2(at)cn(dot)fujitsu(dot)com>
Subject: [patch] some PQExpBuffer are not destroyed in pg_dump
Date: 2020-04-07 02:42:40
Message-ID: 05bcbc5857f948efa0b451b85a48ae10@G08CNEXMBPEKD06.g08.fujitsu.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi al

In getDefaultACLs function, some PQExpBuffer are not destroy

File: src/bin/pg_dump/pg_dump.c
DefaultACLInfo *
getDefaultACLs(Archive *fout, int *numDefaultACLs)
{
......
if (fout->remoteVersion >= 90600)
{
PQExpBuffer acl_subquery = createPQExpBuffer(); // *** acl_subquery not destroyed ***
PQExpBuffer racl_subquery = createPQExpBuffer(); // *** racl_subquery not destroyed ***
PQExpBuffer initacl_subquery = createPQExpBuffer(); // *** initacl_subquery not destroyed ***
PQExpBuffer initracl_subquery = createPQExpBuffer(); // *** initracl_subquery not destroyed ***

buildACLQueries(acl_subquery, racl_subquery, initacl_subquery,
initracl_subquery, "defaclacl", "defaclrole",
"CASE WHEN defaclobjtype = 'S' THEN 's' ELSE defaclobjtype END::\"char\"",
dopt->binary_upgrade);

appendPQExpBuffer(query, "SELECT d.oid, d.tableoid, "
"(%s d.defaclrole) AS defaclrole, "
"d.defaclnamespace, "
"d.defaclobjtype, "
"%s AS defaclacl, "
"%s AS rdefaclacl, "
"%s AS initdefaclacl, "
"%s AS initrdefaclacl "
"FROM pg_default_acl d "
"LEFT JOIN pg_init_privs pip ON "
"(d.oid = pip.objoid "
"AND pip.classoid = 'pg_default_acl'::regclass "
"AND pip.objsubid = 0) ",
username_subquery,
acl_subquery->data,
racl_subquery->data,
initacl_subquery->data,
initracl_subquery->data);
}
......

Here is a patch.

Best Regards!

Attachment Content-Type Size
pg_dump.patch application/octet-stream 506 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2020-04-07 02:53:05 Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Previous Message Amit Kapila 2020-04-07 02:35:57 Re: WAL usage calculation patch