Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions?
Date: 2020-02-23 07:27:57
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sat, Feb 22, 2020 at 10:22:27PM +0100, Daniel Gustafsson wrote:
> Turns out that we in heap_multi_insert missed to call log_heap_new_cid for the
> first tuple inserted, we only do it in the loop body for the subsequent ones.
> With the attached patch, the v6 of this patch posted upthead pass the tests for
> me. I have a v7 brewing which I'll submit shortly, but since this fix
> unrelated to that patchseries other than as a pre-requisite I figured I'd post
> that separately.

Good catch. I would not backpatch that as it is not a live bug
because heap_multi_insert() is not used for catalogs yet. With your
patch, that would be the case though..

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter J. Holzer 2020-02-23 10:19:28 Re: DB running out of memory issues after upgrade
Previous Message Michael Paquier 2020-02-23 07:12:57 Re: [Patch] Make pg_checksums skip foreign tablespace directories