Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions?

From: Andres Freund <andres(at)anarazel(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions?
Date: 2020-02-24 23:29:03
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On 2020-02-23 16:27:57 +0900, Michael Paquier wrote:
> On Sat, Feb 22, 2020 at 10:22:27PM +0100, Daniel Gustafsson wrote:
> > Turns out that we in heap_multi_insert missed to call log_heap_new_cid for the
> > first tuple inserted, we only do it in the loop body for the subsequent ones.
> > With the attached patch, the v6 of this patch posted upthead pass the tests for
> > me. I have a v7 brewing which I'll submit shortly, but since this fix
> > unrelated to that patchseries other than as a pre-requisite I figured I'd post
> > that separately.

Thanks for finding!

> Good catch. I would not backpatch that as it is not a live bug
> because heap_multi_insert() is not used for catalogs yet. With your
> patch, that would be the case though..

Thanks for pushing.

I do find it a bit odd that you essentially duplicated the existing
comment in a different phrasing. What's the point?


Andres Freund

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-02-24 23:29:28 Re: Memory-Bounded Hash Aggregation
Previous Message Dave Cramer 2020-02-24 23:22:21 Re: Error on failed COMMIT