| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Mark Dilger <hornschnorter(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Checking return value of SPI_execute |
| Date: | 2019-11-06 04:27:57 |
| Message-ID: | 20191106042757.GE1604@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 05, 2019 at 05:21:25PM -0800, Mark Dilger wrote:
> please find attached a patch fixing a problem previously discussed [1] about
> the code inappropriately ignoring the return value from SPI_execute.
>
> I will be adding this to https://commitfest.postgresql.org/26/
> shortly.
Yes, this should be fixed.
> - SPI_execute(query, true, 0);
> + spi_result = SPI_execute(query, true, 0);
> + if (spi_result < 0)
> + elog(ERROR, "SPI_execute returned %s", SPI_result_code_string(spi_result));
Any queries processed in xml.c are plain SELECT queries, so it seems
to me that you need to check after SPI_OK_SELECT as only valid
result.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-11-06 04:43:14 | Re: Include RELKIND_TOASTVALUE in get_relkind_objtype |
| Previous Message | Michael Paquier | 2019-11-06 04:13:12 | Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message. |