| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | Gilles Darold <gilles(at)darold(dot)net>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message. |
| Date: | 2019-11-06 04:13:12 |
| Message-ID: | 20191106041312.GD1604@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 06, 2019 at 12:57:10PM +0900, Etsuro Fujita wrote:
> Thanks for the patch! I added the commit message. Does that make
> sense? If there are no objections, I'll apply the patch to all
> supported branches.
"postgres_fdw foreign tables" sounds weird to me. Could "foreign
tables using postgres_fdw" be a better wording? I am wondering as
well if we should not split this information into two parts: one for
the actual error message which only mentions foreign tables, and a
second one with a hint to mention that postgres_fdw has been used.
We could have more test cases with 2PC in this module, not necessarily
the responsibility of this patch, but while we're on it..
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-11-06 04:27:57 | Re: Checking return value of SPI_execute |
| Previous Message | Andrew Gierth | 2019-11-06 04:08:33 | Re: Keep compiler silence (clang 10, implicit conversion from 'long' to 'double' ) |