Improve error detections in TAP tests by spreading safe_psql

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Improve error detections in TAP tests by spreading safe_psql
Date: 2019-08-28 06:49:46
Message-ID: 20190828064946.GJ1965@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

This is a follow-up of the discussion which happened here after Tom
has committed fb57f40:
https://www.postgresql.org/message-id/20190828012439.GA1965@paquier.xyz

I have reviewed the TAP tests, and we have much more spots where it
is better to use PostgresNode::safe_psql instead PostgresNode::psql so
as the test dies immediately if there is a failure on a query which
should never fail.

Attached are the spots I have found. Any thoughts or opinions?
Thanks,
--
Michael

Attachment Content-Type Size
tap-psql-safe-v1.patch text/x-diff 13.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2019-08-28 06:51:29 Re: refactoring - share str2*int64 functions
Previous Message movead.li@highgo.ca 2019-08-28 06:48:39 Re: Re: Email to hackers for test coverage