| From: | "movead(dot)li(at)highgo(dot)ca" <movead(dot)li(at)highgo(dot)ca> |
|---|---|
| To: | "Michael Paquier" <michael(at)paquier(dot)xyz> |
| Cc: | ibrar(dot)ahmad <ibrar(dot)ahmad(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Peter Geoghegan" <pg(at)bowt(dot)ie>, "Robert Haas" <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Re: Email to hackers for test coverage |
| Date: | 2019-08-28 06:48:39 |
| Message-ID: | 2019082814483652735952@highgo.ca |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 28 Aug 2019 11:30:23 +0800 michael(at)paquier(dot)xyz wrote
>- numeric is not a test suite designed for sorting, and hijacking it
>to do so it not a good approach.
Absolutely agreement. We can wait for repling from
Robert and Peter G.
>- it would be good to get coverage for the two extra code paths while
>we are on it with NULL datums.
The remained untested line in ApplySortComparator() can be never
reached I think, and I have explained it on last mail.
Or I don't fully understand what you mean?
>- There is no need for two INSERT queries, I am getting the same
>coverage with only one.
Yes It is my mistake, the key point is 'ORDER BY n1 DESC' not the
'INSERT'. Infact it can run the code line without any of the two INSERT.
--
Movead
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-08-28 06:49:46 | Improve error detections in TAP tests by spreading safe_psql |
| Previous Message | Moon, Insung | 2019-08-28 06:43:02 | Performance improvement of WAL writing? |