| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: refactoring - share str2*int64 functions |
| Date: | 2019-08-28 06:51:29 |
| Message-ID: | alpine.DEB.2.21.1908280841350.28828@lancre |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bonjour Michaël,
>> So I'll set out to write and use "pg_strtou?int64", i.e. 2 functions, and
>> then possibly generalize to lower sizes, 32, 16, depending on what is
>> actually needed.
>
> I am interested in this patch, and the next commit fest is close by.
> Are you working on an updated version? If not, do you mind if I work
> on it and post a new version by the beginning of next week based on
> all the feedback gathered?
Here is an updated patch for the u?int64 conversion functions.
I have taken the liberty to optimize the existing int64 function by
removing spurious tests. I have not created uint64 specific inlined
overflow functions.
If it looks ok, a separate patch could address the 32 & 16 versions.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| str2int-5.patch | text/x-diff | 21.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-08-28 07:13:09 | Re: refactoring - share str2*int64 functions |
| Previous Message | Michael Paquier | 2019-08-28 06:49:46 | Improve error detections in TAP tests by spreading safe_psql |