Re: tableam: inconsistent parameter name

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: tableam: inconsistent parameter name
Date: 2019-06-07 16:52:29
Message-ID: 20190607165229.z5hp7omlzymtytts@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2019-06-07 12:37:33 -0400, Robert Haas wrote:
> TableAmRoutine's index_build_range_scan thinks that parameter #8 is
> called end_blockno, but table_index_build_range_scan and
> heapam_index_build_range_scan and BRIN's summarize_range all agree
> that it's the number of blocks to be scanned. I assume that this got
> changed at some point while Andres was hacking on it and this one
> place just never got updated.

Not sure where it came from :/

> Proposed patch attached. Since this seems like a bug, albeit a
> harmless one, I propose to commit this to v12.

Yea, please do!

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-06-07 17:11:21 Re: tableam: inconsistent parameter name
Previous Message Andres Freund 2019-06-07 16:51:05 Re: Custom table AMs need to include heapam.h because of BulkInsertState