| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: tableam: inconsistent parameter name |
| Date: | 2019-06-07 17:11:21 |
| Message-ID: | CA+TgmobaXbhgSkVrEYXH7SJm6pGg6hBK743YGQgdAD8VufYVig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 7, 2019 at 12:52 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2019-06-07 12:37:33 -0400, Robert Haas wrote:
> > TableAmRoutine's index_build_range_scan thinks that parameter #8 is
> > called end_blockno, but table_index_build_range_scan and
> > heapam_index_build_range_scan and BRIN's summarize_range all agree
> > that it's the number of blocks to be scanned. I assume that this got
> > changed at some point while Andres was hacking on it and this one
> > place just never got updated.
>
> Not sure where it came from :/
>
> > Proposed patch attached. Since this seems like a bug, albeit a
> > harmless one, I propose to commit this to v12.
>
> Yea, please do!
I found what appears to be another typo very nearby. Attached please
find v2, fixing both issues.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-tableam-Fix-cosmetic-mistakes-related-to-index_bu.patch | application/octet-stream | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-06-07 17:19:12 | Re: tableam: inconsistent parameter name |
| Previous Message | Andres Freund | 2019-06-07 16:52:29 | Re: tableam: inconsistent parameter name |