| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | tableam: inconsistent parameter name |
| Date: | 2019-06-07 16:37:33 |
| Message-ID: | CA+TgmoY49ManQWnJtiwkuytXBkmyTuDFqb74Pr4Zn2Nq9TuNBQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
TableAmRoutine's index_build_range_scan thinks that parameter #8 is
called end_blockno, but table_index_build_range_scan and
heapam_index_build_range_scan and BRIN's summarize_range all agree
that it's the number of blocks to be scanned. I assume that this got
changed at some point while Andres was hacking on it and this one
place just never got updated.
Proposed patch attached. Since this seems like a bug, albeit a
harmless one, I propose to commit this to v12.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-tableam-Fix-index_build_range_scan-parameter-name.patch | application/octet-stream | 1023 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-06-07 16:51:05 | Re: Custom table AMs need to include heapam.h because of BulkInsertState |
| Previous Message | Alvaro Herrera | 2019-06-07 16:05:26 | Re: tableam: abstracting relation sizing code |