| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: be-gssapi-common.h should be located in src/include/libpq/ |
| Date: | 2019-06-07 12:11:07 |
| Message-ID: | 20190607121106.GW2480@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greetings,
* Michael Paquier (michael(at)paquier(dot)xyz) wrote:
> As mentioned on another thread about test coverage, I have noticed
> that be-gssapi-common.h is not placed at the correct location, even
> its its identication path at the top points to where the file should
> be:
> https://www.postgresql.org/message-id/20190604014630.GH1529@paquier.xyz
>
> The file has been introduced at its current location as of b0b39f72.
> Any objections to something like the attached?
I'm pretty sure it ended up there just because that's how things are in
src/interfaces/libpq. I don't have any objection to moving it, I had
really just been waiting to see where that thread ended up going.
On a quick look, the patch looks fine to me.
Thanks,
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2019-06-07 12:20:37 | Re: Fix inconsistencies for v12 |
| Previous Message | Michael Paquier | 2019-06-07 12:00:43 | Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold" |