Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Subject: Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"
Date: 2019-06-07 12:00:43
Message-ID: 20190607120043.GA13830@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 07, 2019 at 03:44:14PM +0900, Masahiko Sawada wrote:
> BTW while looking GUC variables defined in trgm_op.c the operators in
> each short description seems not correct; there is an extra percent
> sign. Should we also fix them?

Both of you are right here, and the addition documentation looks fine
to me (except the indentation). The fix for the parameter
descriptions can be back-patched safely as they would reload correctly
once the version is updated. Or is that not worth bothering except on
HEAD? Thoughts?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2019-06-07 12:11:07 Re: be-gssapi-common.h should be located in src/include/libpq/
Previous Message Michael Paquier 2019-06-07 11:52:45 Re: Small review comment on pg_checksums