| From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix inconsistencies for v12 |
| Date: | 2019-06-07 12:20:37 |
| Message-ID: | b6fe2513-8768-206a-a128-2a7970da9830@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Amit,
07.06.2019 7:30, Amit Kapila wrote:
> Leaving the changes related to the above two points, I have combined
> all the changes and fixed the things as per my review in the attached
> patch. Alexander, see if you can verify once the combined patch. I
> am planning to commit the attached by tomorrow and then we can deal
> with the remaining two. However, in the meantime, if Andres shared
> his views on the above two points, then we can include the changes
> corresponding to them as well.
Amit, I agree with all of your changes. All I could is to move a dot:
.. (see contrib/postgres_fdw/postgres_fdw.c: postgresBeginDirectModify()
as one example).
Best regards,
Alexander
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-06-07 12:32:37 | Re: tableam: abstracting relation sizing code |
| Previous Message | Stephen Frost | 2019-06-07 12:11:07 | Re: be-gssapi-common.h should be located in src/include/libpq/ |