| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Table AM callbacks referring to heap in declarations (+typos) |
| Date: | 2019-06-01 19:43:11 |
| Message-ID: | 20190601194311.v4x5iaylp7gue4sm@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-06-01 15:37:43 -0400, Michael Paquier wrote:
> On Sat, Jun 01, 2019 at 12:22:10PM -0700, Andres Freund wrote:
> > On 2019-06-01 15:09:46 -0400, Michael Paquier wrote:
> >> While going through the table AM callbacks, I have bumped into a
> >> couple of references to heap. I think that we should make that more
> >> generic by using the term "table" as done when opening relations and
> >> such. Attached is a cleanup patch.
> >
> > I'm unbothered by this, but I'm also not opposed to changing this. It's
> > largely just keeping the previous code / comment.
> >
> >> While on it, I found a set of typos which looked like a copy-pasto
> >> which got spread => "index_nfo".
> >
> > Yea, we should fix this.
>
> Thanks. Do you mind if I fix both then?
I don't mind at all (although it's imo not a fix for the s/heap/table)!
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-06-01 19:44:05 | Re: psql completion bugs with access methods |
| Previous Message | Michael Paquier | 2019-06-01 19:41:29 | Re: psql completion bugs with access methods |