Re: Table AM callbacks referring to heap in declarations (+typos)

From: Andres Freund <andres(at)anarazel(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Table AM callbacks referring to heap in declarations (+typos)
Date: 2019-06-01 19:22:10
Message-ID: 20190601192210.ini6cln7jz43mqcc@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2019-06-01 15:09:46 -0400, Michael Paquier wrote:
> While going through the table AM callbacks, I have bumped into a
> couple of references to heap. I think that we should make that more
> generic by using the term "table" as done when opening relations and
> such. Attached is a cleanup patch.

I'm unbothered by this, but I'm also not opposed to changing this. It's
largely just keeping the previous code / comment.

> While on it, I found a set of typos which looked like a copy-pasto
> which got spread => "index_nfo".

Yea, we should fix this.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-06-01 19:25:29 Re: psql completion bugs with access methods
Previous Message Andres Freund 2019-06-01 19:19:43 Re: Custom table AMs need to include heapam.h because of BulkInsertState