Re: Segfault when restoring -Fd dump on current HEAD

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Hubert Lubaczewski <depesz(at)depesz(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Subject: Re: Segfault when restoring -Fd dump on current HEAD
Date: 2019-04-25 19:05:47
Message-ID: 20190425190547.GA6690@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Mar-10, Dmitry Dolgov wrote:

> Then I guess we need to add the attached patch on top of a pg_dump support for
> table am. It contains changes to use NULL as a default value for owner / defn /
> dropStmt (exactly what we've changed back in 19455c9f56), and doesn't crash,
> since K_VERS is different.

I think this is an open item; we were supposed to do it right after
3b925e905de3, but failed to notice.

Would anybody be too upset if I push this patch now? CC'ed RMT.

Thanks

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-04-25 19:08:36 Re: pg_waldump and PREPARE
Previous Message Tom Lane 2019-04-25 18:50:09 Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6