| From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | michael(at)paquier(dot)xyz |
| Cc: | magnus(at)hagander(dot)net, sfrost(at)snowman(dot)net, robertmhaas(at)gmail(dot)com, peter(dot)eisentraut(at)2ndquadrant(dot)com, kommi(dot)haribabu(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_basebackup ignores the existing data directory permissions |
| Date: | 2019-03-18 10:15:12 |
| Message-ID: | 20190318.191512.92988830.horiguchi.kyotaro@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Mon, 18 Mar 2019 17:16:01 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in <20190318081601(dot)GI1885(at)paquier(dot)xyz>
> On Mon, Mar 18, 2019 at 08:32:44AM +0100, Magnus Hagander wrote:
> > On Mon, Mar 18, 2019 at 7:08 AM Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> >> I definitely think that we should add an option to allow the user to
> >> tell us explicitly what they want here, even if we also go based on what
> >> the created directory has (and in that case, we should make everything,
> >> including the base directory, follow what the user asked for).
> >
> > +1 for having an option to override whatever the default is.
>
> Based on the feedback gathered, having a separate option to enforce
> the default and not touching the behavior implemented until now,
> sounds fine to me.
FWIW +1 from me. That would be like cp -p.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-03-18 10:15:34 | Re: chained transactions |
| Previous Message | Kyotaro HORIGUCHI | 2019-03-18 10:06:35 | Re: [HACKERS] Block level parallel vacuum |