Re: Tighten error control for OpenTransientFile/CloseTransientFile

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Georgios Kokolatos <gkokolatos(at)pm(dot)me>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Tighten error control for OpenTransientFile/CloseTransientFile
Date: 2019-03-07 01:56:25
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Mar 06, 2019 at 02:54:52PM +0000, Georgios Kokolatos wrote:
> Overall the patch looks good and according to the previous
> discussion fulfils its purpose.
> It might be worthwhile to also check for errors on close in
> SaveSlotToPath().

Thanks for the feedback, added. I have spent some time
double-checking this stuff, and noticed that the new errors in
StartupReplicationOrigin() and CheckPointReplicationOrigin() should be
switched from ERROR to PANIC to be consistent. One message in
dsm_impl_mmap() was not consistent either.

Are there any objections if I commit this patch?

Attachment Content-Type Size
transient-fd-error-v2.patch text/x-diff 13.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2019-03-07 02:15:58 Re: [bug fix] Produce a crash dump before main() on Windows
Previous Message Imai, Yoshikazu 2019-03-07 00:59:07 RE: speeding up planning with partitions