Re: Tighten error control for OpenTransientFile/CloseTransientFile

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Georgios Kokolatos <gkokolatos(at)pm(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Tighten error control for OpenTransientFile/CloseTransientFile
Date: 2019-03-08 01:00:05
Message-ID: 20190308010005.GA28241@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Mar-07, Michael Paquier wrote:

> #else
> - close(fd);
> + if (close(fd))
> + {
> + fprintf(stderr, _("%s: could not close file \"%s\": %s"),
> + progname, ControlFilePath, strerror(errno));
> + exit(EXIT_FAILURE);
> + }
> #endif

I think this one needs a terminating \n.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-03-08 01:18:41 Re: pg_basebackup against older server versions
Previous Message Amit Langote 2019-03-08 00:36:07 Re: Update does not move row across foreign partitions in v11