| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Michael Banck <michael(dot)banck(at)credativ(dot)de>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Bernd Helmle <bernd(dot)helmle(at)credativ(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Progress reporting for pg_verify_checksums |
| Date: | 2019-02-04 02:37:46 |
| Message-ID: | 20190204023746.GF1881@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 25, 2018 at 11:45:09PM -0300, Alvaro Herrera wrote:
> Umm, this is established coding pattern in pg_basebackup.c.
> Stylistically I'd change all those cases to "fprintf(stderr,
> isatty(fileno(stderr)) ? "\r" : "\n")" but leave the string alone, since
> AFAIR it took some time to figure out what to do. (I'd also make the
> comment one line instead of four, say "Stay on the same line if
> reporting to a terminal". That makes the whole stanza two lines rather
> than eight, which is the appropriate amount of space for it).
There has been no input from the author for a couple of weeks now, so
I have marked the patch as returned with feedback.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2019-02-04 03:12:17 | Re: Synchronize with imath upstream |
| Previous Message | Michael Paquier | 2019-02-04 02:36:27 | Re: Online verification of checksums |